Skip to content

Add Vivace model - #606

Merged
ElliottKasoar merged 1 commit into
mainfrom
add-vivace
Aug 4, 2026
Merged

Add Vivace model#606
ElliottKasoar merged 1 commit into
mainfrom
add-vivace

Conversation

@joehart2001

@joehart2001 joehart2001 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

add Vivace model

to run it, you do need to downalod the checkpoint and add the path

Model Reference

Linked issue

Resolves #

Progress

  • Model configuration
  • Documentation

Testing

@joehart2001 joehart2001 added the new model Proposals and suggestions for new models to test label Jun 12, 2026

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joehart2001! Can you rebase and fix the pre-commit?

Comment thread pyproject.toml
Comment thread ml_peg/models/get_models.py Outdated
@joehart2001

Copy link
Copy Markdown
Collaborator Author

@ElliottKasoar rebased and updated, is ok?

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming there isn't a built-in way to download any models? I can't test this fully, but it looks ok

@ElliottKasoar ElliottKasoar changed the title add vivace model Add Vivace model Aug 3, 2026
@ElliottKasoar
ElliottKasoar merged commit aafca88 into main Aug 4, 2026
14 checks passed
@ElliottKasoar
ElliottKasoar deleted the add-vivace branch August 4, 2026 13:41
@joehart2001

Copy link
Copy Markdown
Collaborator Author

I'm assuming there isn't a built-in way to download any models? I can't test this fully, but it looks ok

yep doesnt seem like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new model Proposals and suggestions for new models to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants