Checks PayPal's returned business email against RECEIVER_EMAIL#33
Open
hugoatease wants to merge 1 commit into
Open
Checks PayPal's returned business email against RECEIVER_EMAIL#33hugoatease wants to merge 1 commit into
hugoatease wants to merge 1 commit into
Conversation
…VER_EMAIL when a payment is received.
Collaborator
|
Any chance of adding a test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PayPal allows users to have more than one email address attached to their account.
If such an email address is specified as RECEIVER_EMAIL, transaction's verification goes wrong because PayPal returns the primary account's email as receiver_email, but gives the right business address.
This small patch allows to check RECEIVER_EMAIL against returned receiver_email and business email if different.