Skip to content

add assert for min image size #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breznak wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add assert for min image size #331

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a8fe0e
add assert for min image size
breznak Feb 11, 2020
c071e19
Merge branch 'master' into warn_too_small_image
breznak May 16, 2020
cb43e4c
Revert "add assert for min image size"
breznak May 16, 2020
7a39a60
move low-res warning to init
breznak May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions yolact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def make_priors(self, conv_h, conv_w, device):
""" Note that priors are [x,y,width,height] where (x,y) is the center of the box. """
global prior_cache
size = (conv_h, conv_w)
assert(cfg.max_size > 350),"Segmentation does not work with too low-res images. Try providing input images with size atleast 350pix."

@breznak breznak Feb 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 350 a resonable minimum? Guess it should be compared to backbone's sizes (550x550), how do I access that?

@dbolya dbolya Feb 19, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

350 is reasonable, but should this be a warning not an assert? I don't want to limit anyone from testing a low resolution.

Also this should be in YOLACT's init function, not in the make_priors function.

@breznak breznak May 16, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, modified accordingly


with timer.env('makepriors'):
if self.last_img_size != (cfg._tmp_img_w, cfg._tmp_img_h):
Expand Down