Skip to content

Set RABBITMQ_PLUGINS_DIR when starting the server #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akaihola wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Set RABBITMQ_PLUGINS_DIR when starting the server #273

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab940ae
Set RABBITMQ_PLUGINS_DIR when starting the server
akaihola Feb 7, 2022
b8baeb1
Merge branch 'main' into plugin-dir
Apr 30, 2022
4127f7e
Attempt to use subfolders within temporary directory for plugins
Apr 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ CHANGELOG
unreleased
----------

Bugfix
++++++

- Set the `RABBITMQ_PLUGINS_DIR` environment variable when starting the server

Misc
++++

Expand Down
1 change: 1 addition & 0 deletions src/pytest_rabbitmq/factories/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def __init__(
"RABBITMQ_LOG_BASE": logpath + f"/rabbit-server.{port}.log",
"RABBITMQ_MNESIA_BASE": path + "mnesia",
"RABBITMQ_ENABLED_PLUGINS_FILE": plugin_path + "/plugins",
"RABBITMQ_PLUGINS_DIR": plugin_path,

@fizyk fizyk Apr 30, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 maybe skip both settings if the plugin's dir does not exists? question, what happens if we'll point to the real files and paths, will it work?

@fizyk fizyk Apr 30, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my thinking is that there's not much point to point to the default for both of these settings (enabled_plugin_file and plugins_dir) if they are not existing.

"RABBITMQ_NODE_PORT": str(port),
# Use the port number in node name, so multiple instances started
# at different ports will work separately instead of clustering.
Expand Down