Skip to content

Insert generates invalid SQL when multiple rows and values passed#26

Open
balint-balku-scraperapi wants to merge 1 commit into
db-migrate:masterfrom
balint-balku-scraperapi:patch-1
Open

Insert generates invalid SQL when multiple rows and values passed#26
balint-balku-scraperapi wants to merge 1 commit into
db-migrate:masterfrom
balint-balku-scraperapi:patch-1

Conversation

@balint-balku-scraperapi

Copy link
Copy Markdown

insert generates invalid SQL statement when used to fill multiple columns:

db.insert('table',
  [ 'column1', 'column2' ],
  [ [ 'data11', 'data21' ], [ 'data12', 'data22' ] ]
);

delimiters are not added properly so in the final statement parts of the real data get sliced, ending up in statements like this:

INSERT INTO "table" ("column1","column2") VALUES ('data11''data21),('data12''data22);

Signed-off-by: Balint Balku <balint@scraperapi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant