fix: ordered_param_types and add unit test#357
Open
cemremengu wants to merge 1 commit into
Open
Conversation
Refactor sorting of parameter types to sort numerically based on placeholder keys. Add unit test to verify correct sorting of parameter types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ordered_param_types()received inferred parameter types from DataFusion as aHashMapkeyed by strings such as$1,$2, ...,$10. BecauseHashMaps are unordered, the code sorted the keys before building the positional parameter type list returned to the client.However, the keys were sorted lexicographically:
instead of numerically:
For queries with more than nine placeholders, this caused parameter types to be assigned to the wrong positions. For example, the type inferred for
$10could be reported or used as if it belonged to$2. As a result, clients could bind or deserialize values using incorrect PostgreSQL types, such as treating a UUID parameter as a timestamp.The fix was to sort parameters by their numeric suffix: