[Rust] Reject server over-acks - #648
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
Track the highest physical offset handed to each gRPC connection and reject malformed cumulative acknowledgements before they can advance durability state. Preserve pending single records and batches on protocol violations. Fixes databricks#638 Signed-off-by: sama Pyb <peiyibopybsama@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #638.
This change makes the Rust gRPC receiver reject malformed cumulative durability acknowledgements before they mutate client state. It:
A landing-zone observed count is not a safe upper bound because
observe()happens before the bounded outbound channel handoff. A connection-local sent watermark closes that concurrency window and is reset together with the physical offset generator on recovery.How is this tested?
cargo test -p databricks-zerobus-ingest-sdk(162 unit tests plus 24 passing doc tests; 9 doc tests ignored by existing annotations)cargo test -p tests --test rust_tests(93 integration tests)reserve()does not advance the sent watermark1 -> 0 -> 2sequencecargo clippy -p databricks-zerobus-ingest-sdk --all-targets -- -D warningsmake checkgit diff --check