Skip to content

feat: update about-me activity list UI to designs - #1500

Merged
HashEngineering merged 3 commits into
feat/redesign-about-mefrom
feat/about-me-phase-2
Jun 28, 2026
Merged

feat: update about-me activity list UI to designs#1500
HashEngineering merged 3 commits into
feat/redesign-about-mefrom
feat/about-me-phase-2

Conversation

@HashEngineering

@HashEngineering HashEngineering commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Summary by CodeRabbit

  • New Features
    • Added DashPay user interaction bottom sheet displaying user profile, request status, and activity history.
    • Activity section supports filtering by type (All, Received, Sent) with notifications organized by calendar date.
    • Displays absolute timestamps and formatted payment amounts for transactions.
    • Supports contact requests, payments, and transaction detail viewing.

@HashEngineering HashEngineering self-assigned this Jun 19, 2026
@HashEngineering
HashEngineering changed the base branch from master to feat/redesign-about-me June 19, 2026 20:53
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions updating 'about-me activity list UI' but the changeset adds DashPayUserBottomSheet, a new Jetpack Compose bottom sheet component with user profile display and activity notifications—not an update to an existing about-me activity list. Revise the title to accurately reflect the primary change, such as 'feat: add DashPayUserBottomSheet component for user interactions' or 'feat: implement user profile bottom sheet with activity notifications'.
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/about-me-phase-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@HashEngineering

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@wallet/src/de/schildbach/wallet/ui/dashpay/user/DashPayUserBottomSheet.kt`:
- Around line 562-570: The LaunchedEffect that tracks listAtTop changes and
calls onSheetDraggableChanged does not restore draggability when the composable
leaves composition. If ActivitySection exits while the list is scrolled (making
listAtTop false), the sheet remains non-draggable. Add a cleanup block to the
LaunchedEffect using the onDispose hook to call onSheetDraggableChanged(true)
when the effect is disposed, ensuring the bottom sheet draggability is restored
when the composable leaves composition.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 31dae9e2-fa66-42ca-b39c-390670c05816

📥 Commits

Reviewing files that changed from the base of the PR and between 299be32 and d44e8df.

📒 Files selected for processing (1)
  • wallet/src/de/schildbach/wallet/ui/dashpay/user/DashPayUserBottomSheet.kt

@HashEngineering
HashEngineering merged commit 4c9494d into feat/redesign-about-me Jun 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants