Skip to content

Feature/52 support of three dots#79

Open
nkutsche wants to merge 2 commits into
daisy:masterfrom
nkutsche:feature/52-support-of-three-dots
Open

Feature/52 support of three dots#79
nkutsche wants to merge 2 commits into
daisy:masterfrom
nkutsche:feature/52-support-of-three-dots

Conversation

@nkutsche

Copy link
Copy Markdown

Hi,

as I needed the three dot ignore logic (issue #52) for some of my projects, I made a small implementation for it using just a cleaning XSLT inbetween.

It works the same as in XSpec for most cases. The only known cases are three dots in mixed content like <foo>...<bar/></foo>. This is not supported by my implementation, and I don't see an easy way to do it with my approach. But actually, I have never used the mixed-content dots in XSpec, so I am not sure how important it is for others.

So, if you don't have any other plans with this issue, I would be happy if you could include this in the next release!

Best regards,
Nico

@bertfrees bertfrees requested a review from josteinaj April 19, 2023 13:36
@bertfrees

bertfrees commented Apr 19, 2023

Copy link
Copy Markdown
Member

Nice, thank you!

Two suggestions:

  • Perhaps the documentation needs an update?
  • Is the mixed content case something we want to support ideally or not? If yes, I suggest a test case that shows the shortcoming.

@nkutsche

Copy link
Copy Markdown
Author

Hi, sorry hadn't the time to follow up this.

Perhaps the documentation needs an update?

Am I right, that this has to be done in the xprocspec.rng - round about here? And how do I have to generate the HTML documentation? Or is the documentation not generated?

Is the mixed content case something we want to support ideally or not? If yes, I suggest a test case that shows the shortcoming.

As I wrote, I never used that and I don't see any use case for it. After reviewing it again, I'm not even sure if there is an intendet logic behind it or if I just observed some behavior of the XSpec implementation in the past which was just a consequence of thier way to implement the three dots.

@bertfrees

Copy link
Copy Markdown
Member

Indeed, the documentation is generated from the rng file. @josteinaj How does it work exactly?

@bertfrees

bertfrees commented May 25, 2023

Copy link
Copy Markdown
Member

The process is explained in https://github.com/daisy/xprocspec/blob/master/www/documentation/README.md. We can update the www folder if needed. You don't need to worry about that.

@josteinaj josteinaj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tests are successful. Thanks for the PR @nkutsche!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants