Improve handling of versions - #22
Merged
Merged
Conversation
This makes it much easier to work in a loop
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 41.21% 48.30% +7.09%
==========================================
Files 4 4
Lines 330 354 +24
Branches 55 56 +1
==========================================
+ Hits 136 171 +35
+ Misses 164 157 -7
+ Partials 30 26 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthoyt
enabled auto-merge (squash)
August 23, 2025 08:04
cthoyt
disabled auto-merge
August 23, 2025 08:08
cthoyt
enabled auto-merge (squash)
August 23, 2025 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was motivated by #21, where it was annoying to do
str(version)when looping through versions. Now, functions inchembl-downloaderwill also accept integer versions.This also makes some more careful testing of the way that versions are normalized, especially for versions before v10 and the two instances of versions that have a minor (i.e., v22.1 and v24.1)
This allows: