Skip to content

correct typography, correct link display, correct pathways in ACF data for new template locations#179

Open
possumbilities wants to merge 4 commits into
mainfrom
correct-typography
Open

correct typography, correct link display, correct pathways in ACF data for new template locations#179
possumbilities wants to merge 4 commits into
mainfrom
correct-typography

Conversation

@possumbilities

@possumbilities possumbilities commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

  • corrects sizing of type
  • corrects display of links outside of expected button presentation on .topic-summary and focus-area articles
  • updates the JSON data location of templates used by ACF fields
  • reintroduces the newer stylings of the chooser into the chooser properly, and not as patches

Technical details

  • This PR makes several downstream changes to vocabulary.css which will need to be added upstream to Vocabulary
  • The PR also makes changes to downstream chooser, which will need to be added to upstream chooser

Tests

  1. Visit the support page template to verify links display correctly
  2. Edit any page utilizing a new template to verify the correct template loads with appropriate fields
  3. visit the chooser to verify correct stylings load
  4. visit events listing page to verify typography renders correctly

Checklist

  • I have read and understood the Developer Certificate of Origin (DCO), below, which covers the contents of this pull request (PR).
  • My pull request doesn't include code or content generated with AI (also see Avoiding generative AI development tools — Creative Commons Open Source).
  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated unit tests and/or test scripts for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

1 participant