Skip to content

test(driver): cover deadline call sites#4618

Open
aspnxdd wants to merge 1 commit into
cowprotocol:mainfrom
aspnxdd:test/driver-deadline-call-sites
Open

test(driver): cover deadline call sites#4618
aspnxdd wants to merge 1 commit into
cowprotocol:mainfrom
aspnxdd:test/driver-deadline-call-sites

Conversation

@aspnxdd

@aspnxdd aspnxdd commented Jul 11, 2026

Copy link
Copy Markdown

Description

Adds driver deadline tests.

Fixes #4495

Changes

  • Expired solver deadline skips /solve.
  • Post-processing stops when time runs out.
  • Settlement fails after the submission deadline.

How to test

cargo nextest run -p driver 'tests::cases::deadline::' --run-ignored ignored-only

@aspnxdd aspnxdd requested a review from a team as a code owner July 11, 2026 16:02
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@aspnxdd

aspnxdd commented Jul 11, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@aspnxdd

aspnxdd commented Jul 11, 2026

Copy link
Copy Markdown
Author

recheck

github-actions Bot added a commit that referenced this pull request Jul 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test suite for deadline-related scenarios, including expired solver deadlines, post-processing timeouts, and expired settlement submission deadlines. To support these tests, the test setup framework was updated to allow configuring a post-processing concurrency limit and custom deadline offsets. Additionally, the tracking of solve requests in the test solver was refactored from a boolean flag to an atomic counter to accurately count and assert the number of requests. No critical issues were identified in the review.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@@ -0,0 +1,88 @@
use {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

No critical issues found

References
  1. Confirm Clean Reviews: If no critical issues are found, post a single summary comment stating 'No critical issues found' rather than staying silent. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: driver deadline call sites

1 participant