test(driver): cover deadline call sites#4618
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
There was a problem hiding this comment.
Code Review
This pull request introduces a new test suite for deadline-related scenarios, including expired solver deadlines, post-processing timeouts, and expired settlement submission deadlines. To support these tests, the test setup framework was updated to allow configuring a post-processing concurrency limit and custom deadline offsets. Additionally, the tracking of solve requests in the test solver was refactored from a boolean flag to an atomic counter to accurately count and assert the number of requests. No critical issues were identified in the review.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -0,0 +1,88 @@ | |||
| use { | |||
There was a problem hiding this comment.
No critical issues found
References
- Confirm Clean Reviews: If no critical issues are found, post a single summary comment stating 'No critical issues found' rather than staying silent. (link)
Description
Adds driver deadline tests.
Fixes #4495
Changes
/solve.How to test
cargo nextest run -p driver 'tests::cases::deadline::' --run-ignored ignored-only