-
Notifications
You must be signed in to change notification settings - Fork 174
COS-4032: Add numad and numactl packages #4051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dustymabe
merged 2 commits into
coreos:testing-devel
from
angelcerveraroldan:support-numa-numad
Apr 9, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| variant: fcos | ||
| version: 1.6.0 | ||
| systemd: | ||
| units: | ||
| - name: numad.service | ||
| enabled: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../data/commonlib.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| #!/bin/bash | ||
| ## kola: | ||
| ## platforms: qemu | ||
| ## numaNodes: true | ||
| ## minMemory: 2048 | ||
| ## architectures: "!s390x" | ||
| ## description: Verify that numad detects nodes and tracks set -euo pipefail | ||
| ## bindMountHostRO: ["/,/var/cosaroot"] | ||
| ## creationDate: 2026-04-09 | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| # shellcheck disable=SC1091 | ||
| . "$KOLA_EXT_DATA/commonlib.sh" | ||
|
|
||
| if [[ $(systemctl show numad -p ActiveState) != "ActiveState=active" ]]; then | ||
| fatal "numad did not activate" | ||
| fi | ||
|
|
||
| # Call numad to change the already running daemon's settings for -l and -i | ||
| # `-l 7` adds extra information to the logs | ||
| # `-i 5` changes interval from every 15s to every 5s | ||
| numad -l7 -i5 | ||
|
|
||
| if ! lscpu | grep -Eq "NUMA node\(s\):\s*2"; then | ||
| fatal "expected to find exactly 2 numa nodes" | ||
| fi | ||
|
|
||
| # As part of the test we want to run a somewhat intensive process, so that | ||
| # we can verify that numad is successfully tracking processes. Here we | ||
| # use the same pattern of using a mounted in COSA as the container root as: | ||
| # https://github.com/coreos/coreos-assembler/blob/8dbfe3ea8b8f571e732e8cc0ab307e983a0be1f3/mantle/cmd/kola/resources/iscsi_butane_setup.yaml#L102-L113 | ||
| podman run --privileged --name stress-ng --pid=host \ | ||
| --volume=root:/root/:nocopy --volume=vartmp:/var/tmp/:nocopy \ | ||
| --workdir /root --rootfs /var/cosaroot \ | ||
| stress-ng --temp-path /var/tmp --vm 1 --vm-bytes 1024M --timeout 25s | ||
|
|
||
| logfile="/var/log/numad.log" | ||
| for node in 0 1; do | ||
| # Different versions of numad have a slightly different format for the log file, | ||
| # e.g. MBs_total vs MBs_tot. This pattern should match both versions. | ||
| if ! grep -Eq "Node.${node}.*MBs_tot(al)?.*CPUs_tot(al)?" "$logfile"; then | ||
| fatal "Numad didn't detect Node ${node}" | ||
| fi | ||
| done | ||
|
|
||
| # Check that the stress test was being monitored by numad | ||
| if ! grep -q "stress-ng-vm" "$logfile"; then | ||
| fatal "Numad is not monitoring the stress test" | ||
| fi | ||
|
|
||
| ok "Numad working as expected" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.