Resolve appstore deep links across sources#278
Open
sifounak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #277 .
This PR updates
pebble://appstore/{id}deep-link handling so app store links can resolve listings across multiple app store sources, instead of assuming only the legacy Rebble feed. This fixes cases where a valid listing exists only in the newer RePebble/Pebble app store and the current app opens a blank app detail screen.Background
The existing deep-link handler routed
pebble://appstore/{id}to the Rebble app store source only. That works for older Rebble-hosted listings, but fails for newer listings that only exist in the RePebble/Pebble feed, such as Pebble AlarmSync.Since app store IDs are source-scoped in the app model, a deep link should resolve the
{id}against known app store sources before navigating to the listing detail screen.Changes
PebbleWebServices.RealPebbleDeepLinkHandlersopebble://appstore/{id}:storedIdandstoreSource, preserving the existing source-scoped detail route.pebble://appstore/{id}?source=pebblepebble://appstore/{id}?source=repebblepebble://appstore/{id}?source=rebblePebbleWebServicesimplementation for the new interface method.Notes On ID Conflicts
This keeps treating app store IDs as source-scoped rather than globally unique. If the same ID appears in multiple stores and no source hint is provided, the resolver uses the deterministic priority order above. Source hints can be used where collision-proof links are needed.
Testing