Native websockets for Android#268
Draft
tim-becker wants to merge 1 commit into
Draft
Conversation
- Add native Android WebSocket support for PKJS to avoid WebView-originated `Origin: null` headers. - Share the WebSocket JS shim between Android and iOS. - Align Android and iOS native WebSocket lifecycle behavior. - Fix `close()` during `CONNECTING` so it dispatches close and cannot later dispatch open. - Validate WebSocket URLs, subprotocols, close codes, close reasons, and negotiated subprotocols on the native side. - Guard native bridge calls against duplicate connect and send-before-open cases. - Preserve binary/text message transfer through the native bridge. - Add focused Android instrumentation coverage for: - no `Origin` header - subprotocol preservation - JS-to-native and native-to-JS messages - close during `CONNECTING` - unexpected negotiated subprotocol rejection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245
Origin: nullheaders.close()duringCONNECTINGso it dispatches close and cannot later dispatch open.OriginheaderCONNECTING