Respect phone Do Not Disturb for incoming calls#260
Open
alonmln wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Small follow-up for maintainer triage: this PR is CI-green and CLA-green, and I manually tested it on a Samsung Galaxy S26 / Android 16 with a real watch. The behavior change is scoped to the existing "Respect Phone Do Not Disturb" setting. When the setting is off, call behavior should stay unchanged. When it is on and phone DND is active, calls are only forwarded to the watch if Android's notification ranking says the call is allowed by DND policy. Happy to adjust the implementation if there is a preferred architecture for call/notification coordination. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing "Respect Phone Do Not Disturb" setting so it also applies to incoming phone calls, not only regular notifications.
When Android Do Not Disturb is active and the setting is enabled, incoming calls are only forwarded to the watch if Android's notification ranking says the call is allowed by the phone's DND policy. If no matching call ranking is available in time, the call is conservatively suppressed from the watch.
Details
InCallServiceInCallServiceownership so the legacy receiver does not reclaim a call while DND ranking is pending.Testing
./gradlew :libpebble3:testDebugUnitTest --tests io.rebble.libpebblecommon.calls.CallDoNotDisturbFilterTest./gradlew testDebugUnitTest./gradlew :composeApp:assembleDebug