Add in Blood Oxygen support

[32bitx64bit]

Adds in blood oxygen support.

Related commits :
coredevices/pebbleos-nonfree#4
coredevices/mobileapp#267

[32bitx64bit]

Was tested on my pebble watch.

Power draw was for obvious reasons, higher than having just HR or neither activated.

Code was tested, and from my testing over the week, seems to work well.

[ericmigi]

very cool! do you happen to have any other SP02 enabled devices to benchmark against? did you add UI to display this on watch?

cc @sjp4

[gmarull]

Thanks for the contribution, however, this is not mergeable as is. Make sure to remove unnecessary changes (e.g. why enable a demo app at board level?), group changes in logical commits, CI green, etc. (check contributing guidelines). Changes in the nonfree repo also need better explanation.

[32bitx64bit]

very cool! do you happen to have any other SP02 enabled devices to benchmark against? did you add UI to display this on watch?

cc @sjp4

I sadly do not have any devices to monitor SpO2 outside of my Pebble.

Well I guess my Bangle could work? But they also dont have blood oxygen support 😂

If anyone does have one though feel free to test.

[32bitx64bit]

Thanks for the contribution, however, this is not mergeable as is. Make sure to remove unnecessary changes (e.g. why enable a demo app at board level?), group changes in logical commits, CI green, etc. (check contributing guidelines). Changes in the nonfree repo also need better explanation.

Appreciate the feedback, I'll fixup the PR and get it ready when I get some free time.

[32bitx64bit]

If you have any other requests just lmk!

I'm pretty open, and have 2 days off work of free time.

[toxuin]

I'm installing this and going to compare it with Ultrahuman Air ring which has SpO2 sensor. Will report back.

From looking at the code - it looks quite good! I like hrm_enable(HRMDevice *dev, HRMFeature features, bool low_latency) - clearly a win for both those who need the feature (they get the feature lol) and those who don't (they get more battery life).

One thing I found that may or may not be an actual problem (I'm not that intimately familiar with the codebase yet) is the teardown path prv_activity_spo2_deinit. Seems like you're pausing both activity algo and workout hr in prv_activity_spo2_set_sampling but only unpause activity one and not the workout one. Someone who understands what's going on better than me - please review this path to see if that is an actual issue, or if there's some other thing that unpauses it, or if I'm just not understanding how things work 😅

[32bitx64bit]

I'm installing this and going to compare it with Ultrahuman Air ring which has SpO2 sensor. Will report back.

From looking at the code - it looks quite good! I like hrm_enable(HRMDevice *dev, HRMFeature features, bool low_latency) - clearly a win for both those who need the feature (they get the feature lol) and those who don't (they get more battery life).

One thing I found that may or may not be an actual problem (I'm not that intimately familiar with the codebase yet) is the teardown path prv_activity_spo2_deinit. Seems like you're pausing both activity algo and workout hr in prv_activity_spo2_set_sampling but only unpause activity one and not the workout one. Someone who understands what's going on better than me - please review this path to see if that is an actual issue, or if there's some other thing that unpauses it, or if I'm just not understanding how things work 😅

Appreciate it man! ❤️

[32bitx64bit]

I'm installing this and going to compare it with Ultrahuman Air ring which has SpO2 sensor. Will report back.
From looking at the code - it looks quite good! I like hrm_enable(HRMDevice *dev, HRMFeature features, bool low_latency) - clearly a win for both those who need the feature (they get the feature lol) and those who don't (they get more battery life).
One thing I found that may or may not be an actual problem (I'm not that intimately familiar with the codebase yet) is the teardown path prv_activity_spo2_deinit. Seems like you're pausing both activity algo and workout hr in prv_activity_spo2_set_sampling but only unpause activity one and not the workout one. Someone who understands what's going on better than me - please review this path to see if that is an actual issue, or if there's some other thing that unpauses it, or if I'm just not understanding how things work 😅

Appreciate it man! ❤️

Good catch, was indeed a bug. Fixed it.

[toxuin]

It works, and it tracks with Ultrahuman Ring Air within 1%!

I haven't encountered any crashes. Activity detection algo works with it, too.

I don't have any battery stats info due to the app being built by me (not Core Devices) and lacking ability to login with my Pebble account, unfortunately.

BTW, it seems like you're building the SpO2 test app into retail firmware. Looking at other test apps - they aren't included when release config is enabled.

[32bitx64bit]

It works, and it tracks with Ultrahuman Ring Air within 1%!

I haven't encountered any crashes. Activity detection algo works with it, too.

I don't have any battery stats info due to the app being built by me (not Core Devices) and lacking ability to login with my Pebble account, unfortunately.

BTW, it seems like you're building the SpO2 test app into retail firmware. Looking at other test apps - they aren't included when release config is enabled.

Awesome, appreciate the testing.

As for battery, I'm on day 2, at 44%. So battery drain is definitely higher when SpO2 is enabled (which is expected)

I have SpO2 track interval at 10 minutes, same thing for the HR, so honestly not bad.
(For most use cases I'd probably recomend setting it to 30 minute intervals, as blood oxygen doesn't change much)

[toxuin]

Whoa - no way you lost 56% in 2 days! 😅 I'm on day 2 as well and I'm at 83% with doing tons of comms (flashing firmware and debugging watchfaces), occasional runs of SpO2 tester app and a custom watchface that loves haptic feedback.

Honestly, for me at least, I have not noticed any drastic change in battery drain.

[32bitx64bit]

Whoa - no way you lost 56% in 2 days! 😅 I'm on day 2 as well and I'm at 83% with doing tons of comms (flashing firmware and debugging watchfaces), occasional runs of SpO2 tester app and a custom watchface that loves haptic feedback.

Honestly, for me at least, I have not noticed any drastic change in battery drain.

I have HR + SpO2 tracking on. With intervals of 10 minutes between readings. It'd probably be better if I set spo2 to 30 minute intervals.

Not sure if you're also using background tracking

[toxuin]

Update on the power draw: over last ~5 days, I observed about 8-10% drop per day with 10-minute measurement (both HR + SpO2). I now lowered it to read SpO2 once per hour and will report back in a few days on how that changed things.

[ericmigi]

exciting to see, thanks for sharing the progress