chore: normalize Node version declarations to .nvmrc source of truth [AIS-54]#11036
Open
ethan ozelius (ethan-ozelius-contentful) wants to merge 1 commit into
Open
chore: normalize Node version declarations to .nvmrc source of truth [AIS-54]#11036ethan ozelius (ethan-ozelius-contentful) wants to merge 1 commit into
ethan ozelius (ethan-ozelius-contentful) wants to merge 1 commit into
Conversation
ethan ozelius (ethan-ozelius-contentful)
requested review from
a team
as code owners
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
![wiz-inc-38d59fb8d7[bot]](https://avatars.githubusercontent.com/u/472182?s=60&v=4){kind=small}
| @@ -1,4 +1,5 @@ | |||
| FROM node:21-alpine AS base | |||
| ARG NODE_VERSION | |||
| FROM node:${NODE_VERSION}-alpine AS base | |||
There was a problem hiding this comment.
Missing User Instruction
on resource FROM node:${NODE_VERSION}-alpine AS base
More Details
This rule checks whether a `USER` instruction is specified in the Dockerfile. The rule fails when the `USER` instruction is missing, causing the container to run with root privileges (UID 0). If an attacker compromises an application running as root, they gain the privileges needed to potentially escape the container and attack the host node. It also increases the blast radius of a breach, allowing full control to modify files or install malware within the container. Enforcing a non-root user is a fundamental security measure that minimizes the attack surface and contains the impact of a potential compromise.
Expected
The Dockerfile stage should contain the 'USER' instruction
Found
The Dockerfile stage does not contain any 'USER' instruction
Rule ID: b92f539f-06cf-49ba-8beb-7be068868ecb
To ignore this finding as an exception, reply to this conversation with #wiz_ignore reason
If you'd like to ignore this finding in all future scans, add an exception in the .wiz file (learn more) or create an Ignore Rule (learn more).
To get more details on how to remediate this issue using AI, reply to this conversation with #wiz remediate
ethan ozelius (ethan-ozelius-contentful)
force-pushed
the
migrate/node-normalization
branch
from
9850d47 to
3e58b9d
Compare
| # pull official base image | ||
| FROM node:20-buster-slim | ||
| ARG NODE_VERSION | ||
| FROM node:${NODE_VERSION}-buster-slim |
Contributor
Author
There was a problem hiding this comment.
what is even going on?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated by ai-repo-migrator as part of the fleet-wide Node normalization initiative (AIS-54).
What changed
.nvmrcis now the single source of truth for the Node versionnode-version-file: .nvmrcinstead of a hardcoded versionARG NODE_VERSIONsourced from.nvmrcengines.nodeandvolta.nodeinpackage.jsonare aligned to the same versionWhy
Collapsing ~2.7 declaration sites per repo to one means future Node CVE bumps are a single-file change per repo, opened automatically by Renovate. See AIS-54 for full context.