Only forward stdin to containers during run and exec commands - #1540
Open
mokibit wants to merge 3 commits into
Open
Only forward stdin to containers during run and exec commands#1540mokibit wants to merge 3 commits into
run and exec commands#1540mokibit wants to merge 3 commits into
Conversation
Podman-compose was incorrectly forwarding its own stdin to all podman subprocesses, including containers started via `up`. Now only `run` and `exec` commands can read stdin, matching docker-compose behavior. Signed-off-by: Monika Kairaityte <monika@kibit.lt>
It allows the stdin behavior integration tests to pipe data into podman-compose subprocesses. Signed-off-by: Monika Kairaityte <monika@kibit.lt>
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
podman-composewas incorrectly forwarding its own stdin to all podman subprocesses, including containers started viaup. Now onlyrunandexeccommands can read stdin, matchingdocker-composebehavior.Missing stdin tests were added.
For more on
docker-compose upnot being interactive, see this discussion:docker/compose#3081
Fixes #385.