pass stop_grace_period as --stop-timeout to podman create#1485
Open
thrawn-sh wants to merge 1 commit into
Open
pass stop_grace_period as --stop-timeout to podman create#1485thrawn-sh wants to merge 1 commit into
thrawn-sh wants to merge 1 commit into
Conversation
podman-compose passes stop_signal to podman create via --stop-signal but never passes stop_grace_period as --stop-timeout. This means containers are created with podman's default stop timeout of 10 seconds regardless of the compose file setting. When podman stops a container (e.g. during recreation on up), it uses the container's embedded stop timeout, causing a premature SIGKILL after 10 seconds even when stop_grace_period is set to a higher value. Parse stop_grace_period with str_to_seconds and pass it as --stop-timeout to podman create, matching how stop_signal is already handled. Signed-off-by: Alexander Dreweke <alexander@dreweke.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
podman-compose passes stop_signal to podman create via --stop-signal but never passes stop_grace_period as --stop-timeout. This means containers are created with podman's default stop timeout of 10 seconds regardless of the compose file setting.
When podman stops a container (e.g. during recreation on up), it uses the container's embedded stop timeout, causing a premature SIGKILL after 10 seconds even when stop_grace_period is set to a higher value.
Parse stop_grace_period with str_to_seconds and pass it as --stop-timeout to podman create, matching how stop_signal is already handled.