Support configs: from Compose spec#1473
Open
overhacked wants to merge 5 commits into
Open
Conversation
overhacked
force-pushed
the
overhacked/configs-compose-spec
branch
from
1b3ea5d to
4c29688
Compare
Configs allow content specified in the compose file, in environment variables, in local files, and in OCI artifacts to be mounted in the container. They are similar to volume-mounting a single file but with more options for where the content is stored. See https://github.com/compose-spec/compose-spec/blob/main/08-configs.md and https://github.com/compose-spec/compose-spec/blob/main/05-services.md#configs for details. Resolves containers#835. Signed-off-by: Ross Williams <ross@ross-williams.net>
Functions under test:
- `container_to_args_configs`
- Correctly convert service.configs to podman create arguments
- For environment and content configs, idempotently create artifacts
and re-create when content modified on subsequent runs of compose up
- For external configs, check for artifact existence
- `compose_down`
- Delete config artifacts if they were created by podman compose
- Use dependency logic to determine if any config artifacts should be
excluded from deletion
Signed-off-by: Ross Williams <ross@ross-williams.net>
overhacked
force-pushed
the
overhacked/configs-compose-spec
branch
2 times, most recently
from
2cfbc64 to
e783a05
Compare
Configs rely on podman artifact support, which was stabilized in 5.6.0. Signed-off-by: Ross Williams <ross@ross-williams.net>
Signed-off-by: Ross Williams <ross@ross-williams.net>
overhacked
force-pushed
the
overhacked/configs-compose-spec
branch
from
93b832b to
7a5f2c8
Compare
p12tic
reviewed
Jun 13, 2026
Collaborator
|
Rather large PR, will take some time to review. |
Mistake apply XOR logic to mutually-exclusive parameters Signed-off-by: Ross Williams <ross@ross-williams.net>
Author
|
Understandable. Most of the line count is tests, though. Changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configs:andservices.*.configs:allow content specified in the compose file, in environment variables, in local files, and in OCI artifacts to be mounted in the container. They are similar to volume-mounting a single file but with more options for where the content is stored. See https://github.com/compose-spec/compose-spec/blob/main/08-configs.md and https://github.com/compose-spec/compose-spec/blob/main/05-services.md#configs for details.Resolves #835.