support cgroup-conf in compose yaml file#1382
Open
JimmyMa wants to merge 3 commits into
Open
Conversation
JimmyMa
force-pushed
the
cgroup-conf
branch
2 times, most recently
from
4bc4034 to
e11145d
Compare
p12tic
reviewed
Feb 10, 2026
| services: | ||
| cgroupconf: | ||
| image: nopush/podman-compose-test | ||
| command: ["dumb-init", "/bin/busybox", "httpd", "-f", "-h", "/var/www/html", "-p", "8000"] |
Collaborator
There was a problem hiding this comment.
Maybe read the current cgroup memory.high setting and then check that in the test?
On my machine I can do this via cat /sys/fs/cgroup/$(cat /proc/self/cgroup | sed 's/0:://g')/memory.max.
Author
There was a problem hiding this comment.
Thanks for the suggestion, I added the checks in the test.
p12tic
requested changes
Feb 22, 2026
p12tic
left a comment
p12tic
left a comment
Collaborator
There was a problem hiding this comment.
Marking as "requested changes" for myself.
Author
|
@p12tic could you help to review the change? I think I address your comment. Thank you!!! |
p12tic
approved these changes
Jun 20, 2026
added 3 commits
June 20, 2026 15:07
Signed-off-by: Yun Feng Ma <yma@ddn.com>
Signed-off-by: Yun Feng Ma <yma@ddn.com>
Signed-off-by: Yun Feng Ma <yma@ddn.com>
Collaborator
|
@JimmyMa Could you squash your commits into one? The two subsequent commits currently just fix the first commit - no need to put mistakes into history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Checklist:
Support extention
x-podman.cgroup_confin services, for configuring cgroup v2 parameters of container.Currently the
cgroup-confcan be configured onpodman-composecommand line, likepodman-compose --podman-run-args="--cgroup-conf=memory.high=512M", but it's not declarative. One requirement to configure cgroup is thememory.high, the value of it ismaxby default, Linux PSI (Pressure Stall Information) needs it to work properly.