refactor: Remove dylints#4183
Open
maurolacy wants to merge 7 commits into
Open
Conversation
added 6 commits
July 6, 2026 11:50
Signed-off-by: Mauro Lacy <mauro.lacy@acronis.com>
Signed-off-by: Mauro Lacy <mauro.lacy@acronis.com>
Signed-off-by: Mauro Lacy <mauro.lacy@acronis.com>
Signed-off-by: Mauro Lacy <mauro.lacy@acronis.com>
…ents Signed-off-by: Mauro Lacy <mauro.lacy@acronis.com>
…other docs Signed-off-by: Mauro Lacy <mauro.lacy@acronis.com>
|
Important Review skippedToo many files! This PR contains 409 files, which is 259 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (409)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…docs Signed-off-by: Mauro Lacy <mauro.lacy@acronis.com>
maurolacy
force-pushed
the
refactor/remove-dylints
branch
from
0ac28cc to
75fb806
Compare
Artifizer
reviewed
Jul 6, 2026
| fail_ci_if_error: false | ||
| token: ${{ secrets.CODECOV_TOKEN }} # Uncomment if required for private repos | ||
|
|
||
| dylint: |
Contributor
There was a problem hiding this comment.
Mmm, I can't see how we replacing it, it's being just removed.
Where is the new 'cargo gears lint' command in CI?
Contributor
There was a problem hiding this comment.
@maurolacy let's take the approach of installing the cargo-gears here and use the lint functionality.
Create a basic manifest target to lint all gears from here
Artifizer
requested changes
Jul 6, 2026
| install-tools: | ||
| @command -v cargo-nextest >/dev/null 2>&1 || cargo install cargo-nextest | ||
|
|
||
| ## List all custom project compliance lints (see tools/dylint_lints/README.md) |
Contributor
There was a problem hiding this comment.
Same here, where do we replace current dylint by 'cargo gears xxx' ?
Contributor
There was a problem hiding this comment.
@maurolacy also it's a good UX improvement to have a list argument in the lint section for dylint. This way we offer a list of the available lints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since dylints have been moved to https://github.com/constructorfabric/cargo-gears, this removes them from here. It also updates the many references to dylints throughout doc comments and docs, removes it from CI, Makefiles, etc.
Closes Bechma/cargo-gears#4.