Skip to content

Add Tariffs Commercial Pricing Logic PRD (cf-bss format) - #4143

Open
Corw1n-of-Amber wants to merge 1 commit into
constructorfabric:mainfrom
Corw1n-of-Amber:add-tariffs-pricing-prd
Open

Add Tariffs Commercial Pricing Logic PRD (cf-bss format)#4143
Corw1n-of-Amber wants to merge 1 commit into
constructorfabric:mainfrom
Corw1n-of-Amber:add-tariffs-pricing-prd

Conversation

@Corw1n-of-Amber

Copy link
Copy Markdown

Summary

  • Adds the adapted Tariffs (Commercial Pricing Logic) PRD under gears/bss/tariffs/docs/PRD.md, in Constructor Studio gears/cf-bss format (17-section outline, cpt-cf-bss-tariffs-* IDs).
  • Source of truth remains unchanged in vhp-architecture (docs/bss/prd/PRD-tariffs-pricing-logic-202604011200/); this is the gears-adapted projection, same approach as the Ledger & Balances PRD.

Validation

  • cfs validate --artifact gears/bss/tariffs/docs/PRD.md --skip-code --local-only → 0 errors, 0 warnings.
  • cfs validate-toc → all TOCs correct.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Corw1n-of-Amber, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b58d5d4b-bb8f-4da0-b5d7-04e77de1f0be

📥 Commits

Reviewing files that changed from the base of the PR and between 322a01f and 933a60f.

📒 Files selected for processing (1)
  • gears/bss/tariffs/docs/PRD.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Mikhail Fedorov <mikhail.fedorov@virtuozzo.com>
@Corw1n-of-Amber
Corw1n-of-Amber force-pushed the add-tariffs-pricing-prd branch from c475d06 to 933a60f Compare July 5, 2026 14:01
@dogbert2021

Copy link
Copy Markdown

Looks good!

@Artifizer
Artifizer requested a review from rostm July 10, 2026 11:04
@Artifizer
Artifizer requested review from dogbert2021 and removed request for rostm August 12, 2026 11:07
@dogbert2021

Copy link
Copy Markdown

From the CT Depot perspective:

  1. Depot Catalog consumes BSS Product & SKU and BSS Plan & Price
  2. BSS Tariffs evaluates their published inputs

Before approval, please reconcile this PRD with the Plan & Price contract.

Plan & Price requires a full effective-price preview for purchase/quote flows, the canonical scope key (planId, currency, region, priceList, phase, priceEligibility, chargeKind), customerGroup PriceList evaluation, and one-to-one formula coverage for flat, per_unit, graduated, volume, and repeating-block package.

The current Tariffs PRD still contains the dropped Volume Variant B and does not explicitly cover per_unit or package. Please correct me if I misunderstood this aspect.

CT Depot will need the capability to show effective price preview for a partner as part of CPQ self-service tool (=Configure, Price, Quote - getting an effective price for a SKU + volume).

@diffora

diffora commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

From the CT Depot perspective:

  1. Depot Catalog consumes BSS Product & SKU and BSS Plan & Price
  2. BSS Tariffs evaluates their published inputs

Before approval, please reconcile this PRD with the Plan & Price contract.

Plan & Price requires a full effective-price preview for purchase/quote flows, the canonical scope key (planId, currency, region, priceList, phase, priceEligibility, chargeKind), customerGroup PriceList evaluation, and one-to-one formula coverage for flat, per_unit, graduated, volume, and repeating-block package.

The current Tariffs PRD still contains the dropped Volume Variant B and does not explicitly cover per_unit or package. Please correct me if I misunderstood this aspect.

CT Depot will need the capability to show effective price preview for a partner as part of CPQ self-service tool (=Configure, Price, Quote - getting an effective price for a SKU + volume).

Hello @dogbert2021 ,

  1. full effective-price - can we consider it as future request and add to the backlog?
  2. Volume Variant B - do you have real use cases for this? If yes we will add it to PRD

@dogbert2021

Copy link
Copy Markdown

@diffora ,

from CT Depot perspective:
Re1: effective price resolution is required in Q1-2027. Can you please share a stable backlog reference for this request?
Re2: institutional procurement often requires fixed budgeting (=not usage based); thus we would need Variant B (=fixed fee for the quantity band reached). It can wait till Q1-2027, however, we also need a stable backlog reference for this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants