Skip to content

Add entire.io extra#62

Merged
yarikoptic merged 4 commits into
mainfrom
enh-entire
Apr 7, 2026
Merged

Add entire.io extra#62
yarikoptic merged 4 commits into
mainfrom
enh-entire

Conversation

@yarikoptic

Copy link
Copy Markdown
Member

as I am exploring it and @candleindark prepping example for STAMPED

FTR my invocation

./setup-yolo.sh --build=yes --packages="ffmpeg,imagemagick,yt-dlp,nodejs,podman,podman-compose,curl,tmux,ncdu,pre-commit,latex-make,xterm,xdotool,psmisc,cowsay" --extras=playwright,entire,deno

locally ATM

@asmacdo asmacdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I have an escape plan if the dockerfile becomes unwieldy I'm not concerned with bloat.

FWIW I think this does highlight an improvement in my WIP way, which is that extras can take arguments ie, version.

Another small concern is that the go version is pinned by the extra. Might hit trouble if we add other go tools.

But since individual extras dont accept args I think let's just merge, and if we hit these issues we can fix then.

@yarikoptic

Copy link
Copy Markdown
Member Author

yeah, I actually also thought to fix it by version, would be prudent... let's do that...

Comment thread images/Dockerfile Outdated
@asmacdo

asmacdo commented Apr 5, 2026

Copy link
Copy Markdown
Member

DONE Could you also add this to the spec?

asmacdo and others added 2 commits April 6, 2026 07:53
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown

pr-scout: spec-audit

✅ Spec update matches code changes

Code change summary

Here's a summary of the new or changed functionality:

  • The Docker image now supports an optional build-time installation of the entire CLI tool (version v0.5.3) when the EXTRA_ENTIRE build argument is set to 1.
  • The setup-yolo.sh script now recognizes and validates entire as a valid extra option when passed via the --extras argument.
  • When setup-yolo.sh is executed with --extras all, it will now automatically include the entire CLI tool in the set of tools to be configured or installed.

Verdict

PASS

The spec update accurately describes all user-visible code changes:

  • The addition of EXTRA_ENTIRE to the build arguments table directly corresponds to the Docker image supporting build-time installation of the entire CLI via this argument.
  • The update to the --extras argument list to include entire directly reflects that setup-yolo.sh now recognizes and validates entire as an extra option.
  • By adding entire to the list of available extras, it is implicitly understood that --extras all will now include it, which aligns with the description of setup-yolo.sh's behavior for all.
  • The spec also details the entire CLI as version v0.5.3, matching the code summary.

@yarikoptic

Copy link
Copy Markdown
Member Author

DONE Could you also add this to the spec?

do you have in CLAUDE.md statement for AIs to review/adjust spec accordingly for any new introduced feature or change in behavior? shouldn't be requiring "manual" labor!

@asmacdo

asmacdo commented Apr 6, 2026

Copy link
Copy Markdown
Member

do you have in CLAUDE.md statement for AIs to review/adjust spec accordingly for any new introduced feature or change in behavior? shouldn't be requiring "manual" labor!

Yes but it merged with the SPEC.md after this PR was created

@yarikoptic

Copy link
Copy Markdown
Member Author

spec audit said green I will proceed

@yarikoptic yarikoptic merged commit 1ab0115 into main Apr 7, 2026
6 checks passed
@yarikoptic yarikoptic deleted the enh-entire branch May 8, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants