ci: declare workflow-level contents: read on ci + nightlies workflows#6051
Open
arpitjain099 wants to merge 1 commit into
Open
ci: declare workflow-level contents: read on ci + nightlies workflows#6051arpitjain099 wants to merge 1 commit into
contents: read on ci + nightlies workflows#6051arpitjain099 wants to merge 1 commit into
Conversation
Member
|
This change is |
RaduBerinde
approved these changes
May 14, 2026
Contributor
Author
|
@RaduBerinde - approved + green; any window to land this when convenient? Happy to rebase if it's drifted. |
Pins the default GITHUB_TOKEN to contents: read on the 6 workflows in .github/workflows/ that don't actually need any write scope: - ci.yaml: PR/push CI suite. - nightlies.yaml: master nightlies entry point. - nightlies-25.2.yaml, nightlies-25.4.yaml, nightlies-26.1.yaml, nightlies-26.2.yaml: per-release nightly stress runs. None call a GitHub API beyond the initial checkout. Left implicit on purpose: - code-cover-gen.yaml uses 'gh pr view' (needs pull-requests: read). - nightly-code-cover.yaml passes github.token to a gh-cli step. - code-cover-publish.yaml writes coverage results. Those three are best declared by a maintainer who knows whether pull-requests: read at workflow or job scope is the right shape. Motivation: CVE-2025-30066 (March 2025 tj-actions/changed-files compromise) exfiltrated GITHUB_TOKEN from workflow logs. Per-workflow caps bound runtime authority irrespective of repo or org default, give drift protection if the default ever widens, and are credited per-file by the OpenSSF Scorecard Token-Permissions check. YAML validated locally with yaml.safe_load. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
chore/declare-workflow-perms-readonly
branch
from
b4731b7 to
90301d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENtocontents: readon the 6 workflows in.github/workflows/that don't actually need any write scope:ci.yaml: PR/push CI suite.nightlies.yaml: master nightlies entry point.nightlies-25.2.yaml,nightlies-25.4.yaml,nightlies-26.1.yaml,nightlies-26.2.yaml: per-release nightly stress runs.None call a GitHub API beyond the initial checkout, so
contents: readis sufficient.Left implicit on purpose:
code-cover-gen.yamlusesgh pr view(needspull-requests: read).nightly-code-cover.yamlpassesgithub.tokento a gh-cli step.code-cover-publish.yamlwrites coverage results.Those three are best declared by a maintainer who knows whether to put the extra scope at workflow or job level.
Why
CVE-2025-30066 (March 2025
tj-actions/changed-filessupply-chain compromise) exfiltratedGITHUB_TOKENfrom workflow logs. Pinning per workflow caps runtime authority irrespective of the repo or org default, gives drift protection if the default ever widens, and is credited per-file by the OpenSSF ScorecardToken-Permissionscheck.YAML validated locally with
yaml.safe_loadon each touched file.