Skip to content

sharedcache: implement minimal version of metadata persistence #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshimhoff wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

sharedcache: implement minimal version of metadata persistence #2577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions objstorage/objstorageprovider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ type Settings struct {
// 2*runtime.GOMAXPROCS is used as the shard count.
CacheShardCount int

// If true, metadata on the mapping from logical block indexes to cache block indexes
// is persisted, implying that the contents in the cache are usable after a server
// restart.
PersistMetadata bool

// TODO(radu): allow the cache to live on another FS/location (e.g. to use
// instance-local SSD).
}
Expand Down
3 changes: 2 additions & 1 deletion objstorage/objstorageprovider/shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ func (p *provider) sharedInit() error {
numShards = 2 * runtime.GOMAXPROCS(0)
}

p.shared.cache, err = sharedcache.Open(p.st.FS, p.st.FSDirName, blockSize, p.st.Shared.CacheSizeBytes, numShards)
p.shared.cache, err = sharedcache.Open(
p.st.FS, p.st.FSDirName, blockSize, p.st.Shared.CacheSizeBytes, numShards, p.st.Shared.PersistMetadata)
if err != nil {
return errors.Wrapf(err, "pebble: could not open shared object cache")
}
Expand Down
Loading