Skip to content

Remove feature flag showMessage. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cloudbees-platform wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove feature flag showMessage. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/com/cloudbees/springboot_fm_example/container/Flags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// Create Roxflags in the Flags container class
public class Flags implements RoxContainer {
// Define the feature flags
public RoxFlag showMessage = new RoxFlag(false);
public final RoxString message = new RoxString("default message");
public final RoxString fontColor = new RoxString("red", new String[] { "red", "green", "blue", "black"});
public final RoxInt fontSize = new RoxInt(12, new int[] { 12, 16, 24 });
Expand Down
8 changes: 2 additions & 6 deletions src/main/java/com/cloudbees/springboot_fm_example/service/DemoService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.cloudbees.springboot_fm_example.service;

import com.cloudbees.springboot_fm_example.container.Flags;
import io.rollout.flags.RoxFlag;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;

Expand All @@ -17,9 +16,6 @@ public DemoService(Flags flags) {

public String demo() {
String demo = " | fontColor: " + flags.fontColor.getValue() + " | fontSize: " + flags.fontSize.getValue();
if (flags.showMessage.isEnabled())
return "message is: " + flags.message.getValue() + demo;
else
return "message is hidden" + demo;
return "message is: " + flags.message.getValue() + demo;
}
}
}