Skip to content

Fix tags facets not being displayed on index page #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdelboca wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix tags facets not being displayed on index page #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46d65f4
Fix tags facets not being displayed
pdelboca Apr 20, 2022
0a63533
Remove class for compatibility with 2.7
pdelboca Apr 20, 2022
0006975
Add conditional testing
pdelboca Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ckanext/showcase/templates/showcase/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,5 @@

{% block secondary_content %}
{{ h.snippet('showcase/snippets/helper.html') }}
<div class="filters">
<div>
{% for facet in c.facet_titles %}
{{ h.snippet('snippets/facet_list.html', title=c.facet_titles[facet], name=facet) }}
{% endfor %}
</div>
<a class="close no-text hide-filters"><i class="fa fa-times-circle icon-remove-sign"></i><span class="text">close</span></a>
</div>
{{ super() }}
{% endblock %}
13 changes: 13 additions & 0 deletions ckanext/showcase/tests/test_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@ def test_showcase_listed_on_index(self, app):
assert "1 showcase found" in response.body
assert "my-showcase" in response.body

def test_tags_facets_are_being_shown(self, app):
factories.Dataset(
type="showcase",
name="my-showcase",
tags=[{"name": "this-must-be-shown"}]
)

response = app.get("/showcase", status=200)
if tk.check_ckan_version(max_version="2.7"):
assert '<span>this-must-be-shown 1</span>' in response.body
else:
assert '<span class="item-label">this-must-be-shown</span>' in response.body


@pytest.mark.usefixtures("clean_db")
class TestShowcaseNewView(object):
Expand Down