Skip to content

Pass dataset name to resource fields snippets #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wardi merged 2 commits into from
Jan 11, 2023
Merged

Pass dataset name to resource fields snippets #354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87e1fb3
Pass dataset name to resource fields snippets
amercader Jan 10, 2023
6d80db8
Add comment about package name vs id
amercader Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ckanext/scheming/templates/scheming/package/snippets/resource_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
errors=errors,
licenses=c.licenses,
entity_type='dataset',
object_type=dataset_type
object_type=dataset_type,
package_id=pkg_name

@wardi wardi Jan 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment here about why we're passing the name as package_id would be good

-%}
{%- endif -%}
{%- endfor -%}
Expand Down
3 changes: 2 additions & 1 deletion ckanext/scheming/templates/scheming/snippets/form_field.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
errors=errors,
licenses=licenses,
entity_type=entity_type,
object_type=object_type
object_type=object_type,
package_id=package_id
-%}