QGOV changes#81
Conversation
|
Let's remove travis configuration completely, it's not really usable anymore. I'll try to review this soonish. |
|
I'll add github action workflow as a separate PR today, so that the action is run for this PR too. |
|
@Zharktas What was wrong with the Github Workflow in this pull request? |
|
The only thing wrong with it, is that it's not run as you have no permissions for this repository. Now that there is a existing workflow, the pull requests will trigger the workflow. And i would like python3 support as separate pull request as python3 support itself does nothing unless CKAN 2.9 is supported as well. There is mine #73, which might do the rest of it once I have time to finish it. |
|
Well, this is just a merge of all changes in our fork except build config specific to our repos. If you want to split it, feel free. I've merged master to resolve the conflicts, though. |
|
I approved running github action, as it is required for the first time. I'm all in for improving archiver itself, it just might take awhile to get it merged :) |
e1fb38d to
98a8166
Compare
- Only run on pull request if targeting master, since 'push' covers most cases except for cross-repo pull requests.
- Also combine duplicate exception blocks
- This allows us to easily apply null-checks to every lookup
3ab9c1f to
76b52ae
Compare
ckanext-s3filestoresetup.pyto requirements files