Skip to content

Fix a hang where ctrl-d can hang the next call to Readline #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tpodowd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix a hang where ctrl-d can hang the next call to Readline #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions terminal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ func (t *Terminal) ioloop() {

expectNextChar = true
switch r {
case 0:
// If ctrl-D is pressed at the beginning of a line before rl.Readline() is
// called, then the terminal won't be in raw mode and will translate the
// ctrl-D to 0. If we return the 0, the operation ioloop will exit and
// the next call to rl.Readline() will hang as nothing will read t.outchan.
// Instead, we can safely ignore this and continue.
continue
case CharEsc:
if t.cfg.VimMode {
t.outchan <- r
Expand Down