Add draft of "yank analyze cluster" CLI - #1020
Open
jchodera wants to merge 1 commit into
Open
Conversation
Member
Author
|
@Lnaden and @andrrizzi : Maybe you can can pull in the latest changes from |
Member
Author
|
Alan Graves suggests we add an option to cluster the whole receptor+ligand complex coordinates, rather than just the ligand coordinates, in case the ligand and protein change conformation together. |
Member
Author
|
Here's the CLI help for @sgill2: |
steven-albanese
approved these changes
Jul 30, 2018
steven-albanese
left a comment
Member
There was a problem hiding this comment.
I can't really comment on the code itself, but I was able to use this for the id1 project. I don't think I ran into any issues or bugs, and the results looked reasonable to me.
Member
Author
|
Thanks! Would be great to get this into the next feature release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an early experimental version of the
yank analyze clusterCLI option needed by @steven-albanese for analyzing Id1 data.The algorithm:
The code could use a lot of refactoring. It currently accesses the
complex.ncNetCDF directly, but this could be greatly simplified as we reorganize and refactor theMultiStateAnalyzerto expose smaller operational chunks via an API.