Skip to content

chore: remove deprecated windows note - #1695

Merged
andrinoff merged 2 commits into
charmbracelet:mainfrom
Jaeiya:patch-1
Aug 6, 2026
Merged

chore: remove deprecated windows note#1695
andrinoff merged 2 commits into
charmbracelet:mainfrom
Jaeiya:patch-1

Conversation

@Jaeiya

@Jaeiya Jaeiya commented May 10, 2026

Copy link
Copy Markdown
Contributor

I'm not sure if this is no longer an issue for all windows versions or just windows 10 & 11. I can only confirm 10 & 11. Let me know if there are any other considerations that need to be added or if we can just remove the note entirely, like I've done.

  • I have read CONTRIBUTING.md.
  • This pull request was approved to be created from a Discord conversation.

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.50%. Comparing base (640d879) to head (106d1fa).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1695      +/-   ##
==========================================
+ Coverage   55.64%   56.50%   +0.85%     
==========================================
  Files          25       25              
  Lines        1310     1315       +5     
==========================================
+ Hits          729      743      +14     
+ Misses        491      482       -9     
  Partials       90       90              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meowgorithm

Copy link
Copy Markdown
Member

We added the ability for Windows to detect terminal size changes a very long time ago, and it should work for both Windows 10 and 11. Thanks for this!

@andrinoff andrinoff changed the title Remove deprecated windows note from WindowSizeMsg docstr chore(examples): deprecated windows note Aug 6, 2026
@andrinoff andrinoff changed the title chore(examples): deprecated windows note chore(examples): remove deprecated windows note Aug 6, 2026
@andrinoff andrinoff changed the title chore(examples): remove deprecated windows note chore: remove deprecated windows note Aug 6, 2026
@andrinoff
andrinoff merged commit af9a33e into charmbracelet:main Aug 6, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants