Add test exercising compilations of same filenames, different directories#28974
Open
bradcray wants to merge 1 commit into
Open
Add test exercising compilations of same filenames, different directories#28974bradcray wants to merge 1 commit into
bradcray wants to merge 1 commit into
Conversation
…ries In a discussion last week, we were musing about how well or poorly the compiler supports multiple files with the same name as long as they don't define duplicate module names (or even if they do). That caused me to write up these tests, which mostly worked as I'd expected. One is not surprising, but seems like an opportunity for improvement, so I've added that as a future as well. It shows that if we need to use a module that we haven't parsed yet, we default to an already-parsed file that doesn't define that module rather than a new one that may. --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a discussion last week, we were musing about how well or poorly the compiler supports multiple files with the same name as long as they don't define duplicate module names (or even if they do). That caused me to write up these tests, which mostly worked as I'd expected. One is not surprising, but seems like an opportunity for improvement, so I've added that as a future as well. It shows that if we need to use a module that we haven't parsed yet, we default to an already-parsed file that doesn't define that module rather than a new one that may.