Larger Spectral Norm Benchmark Case#28895
Conversation
|
One potentially open question on this one: is the "submitted" directory the right place to put this? It's running on a submitted code, but I wasn't entirely sure. |
|
If you don't want to edit the submitted directory, I believe |
|
FWIW, I don't mind editing the submitted directory. I just wasn't sure what made sense in terms of the current directory structure and wanted to confirm. Really whatever is fine with me. |
|
I'd probably edit the other benchmark, not the submitted one. Also, is the intention of this PR to add a perf graph for the larger data size, or just run it with a larger size? |
|
If I understood right, I think Brad wanted to add another graph to maintain continuity for the old one. I just want at least one that takes a less trivial amount of time. All of the spectral norm benchmarks run on relatively small problem sizes right now. |
|
If it were up to me, I'd change all of them to just run on the bigger problem size and drop the size loop that's present, but I'll definitely defer to you all on what's wanted there. |
5ab7610 to
01356f2
Compare
|
Alright, just switched where the new benchmark case was added. |
|
Although, looking at this again, I think this size may be slightly too big for smaller hardware. I'll scale it down a little bit. |
01356f2 to
eeace6a
Compare
|
I think this is good to go on my end. Up to you all what you want to do here though. |
|
Catching up with this, which I hadn't noticed until a mail mentioned it today. @insertinterestingnamehere : I think that in order to get a graph for this, you'll need to add a Sorry not to have seen this earlier, but I'd probably add the new problem size to the submitted rather than blc version, though either is fine. The reason is that I consider the -blc versions to be ones that I might continue to change and experiment over time, whereas the submitted ones are going to remain the same as long as those are the versions we've got submitted on the actual site. It's important to me to continue to run the site's problem size in our nightly testing (which is why I didn't want to just bump up the problem size), but I don't mind adding additional sizes as well. |
|
(that said, using a larger problem size with the -blc version is fine as well… I just don't promise that it will stay in sync with the submitted version over time). |
Signed-off-by: Ian Henriksen <iandhenriksen@gmail.com>
eeace6a to
fb68beb
Compare
jabraham17
left a comment
There was a problem hiding this comment.
Noting that the new graphfile needs to be added to test/GRAPHFILES, otherwise I think this is pretty much ready to merge
This adds a larger spectral norm benchmark case since the existing problem sizes result in near trivial running times.