feat(*): v6#3920
Open
cschroeter wants to merge 18 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| describe('Accordion', () => { | ||
| it('should have no a11y violations', async () => { | ||
| const { container } = render(<ComponentUnderTest />) | ||
| const { container } = await act(async () => render(<ComponentUnderTest />)) |
Member
There was a problem hiding this comment.
Not sure why we need this act for rendering the component. Maybe AI slop?
|
|
||
| export const ComponentUnderTest = (props: ColorPicker.RootProps) => ( | ||
| <ColorPicker.Root defaultValue={parseColor('#eb5e41')} {...props}> | ||
| <ColorPicker.Root defaultValue={parseColor('#eb5e41').toFormat('hsba')} {...props}> |
Member
There was a problem hiding this comment.
I wonder why the extra toFormat('hsba') was added?
| import { mergeProps } from '@zag-js/react' | ||
| import { forwardRef } from 'react' | ||
| import { type HTMLProps, type PolymorphicProps, ark } from '../factory.ts' | ||
| import { parts } from './segment-group.anatomy.ts' |
Member
There was a problem hiding this comment.
This is breaking change we need to document somewhere, since this data-* will now reflect that of radio-group not segment-group anymore
| const SelectImpl = <T extends CollectionItem>(props: SelectRootProps<T>, ref: React.Ref<HTMLDivElement>) => { | ||
| const [presenceProps, selectProps] = splitPresenceProps(props) | ||
| const [useSelectProps, localProps] = createSplitProps<UseSelectProps<T>>()(selectProps, [ | ||
| 'alignItemWithTrigger', |
Member
There was a problem hiding this comment.
We need an example for this prop, its a nice feature that users will like to see (i believe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.