cfengine format ./controls/#3176
Open
olehermanse wants to merge 2 commits into
Open
Conversation
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Member
Author
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13989/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13989/ |
nickanderson
approved these changes
Jun 23, 2026
nickanderson
left a comment
nickanderson
left a comment
Member
There was a problem hiding this comment.
It feels too compact to me.
|
|
||
| # Minimum time (in minutes) which should have passed since the last time | ||
| # the promise was verified before it is checked again. | ||
| ifelapsed => "1"; |
Member
There was a problem hiding this comment.
This feels cramped and hard to scan visually. I would put a blank line between the attribute and the next comment.
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
I agree with Nick about the comments/attributes getting too squished to be easily read. I guess a change to the formatter might be in order for spacing attributes in some cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.