update regression tests and run them in CI tests

.github/workflows/test-unit.yml

@@ -24,4 +24,3 @@ jobs:
         run: |
           python -m pytest tests/unit/ --cov=cdisc_rules_engine --cov-fail-under=75
           python -m pytest tests/QARegressionTests/
-          python -m pytest -m regression tests/QARegressionTests/test_Issues

tests/QARegressionTests/globals.py

@@ -1,10 +1,10 @@
-issue_datails_sheet = "Issue Details"
-dataset_details_sheet = "Dataset Details"
-entity_details_sheet = "Entity Details"
-rules_report_sheet = "Rules Report"
-issue_sheet_coreid_column = "A"
-dataset_sheet_dataset_column = "A"
-rules_sheet_rule_status_column = "F"
-issue_sheet_record_column = "G"
-issue_sheet_variable_column = "I"
-issue_sheet_values_column = "J"
+issue_datails_sheet = "Issue Details"
+dataset_details_sheet = "Dataset Details"
+entity_details_sheet = "Entity Details"
+rules_report_sheet = "Rules Report"
+issue_sheet_coreid_column = "A"
+dataset_sheet_dataset_column = "A"
+rules_sheet_rule_status_column = "F"
+issue_sheet_record_column = "F"
+issue_sheet_variable_column = "H"
+issue_sheet_values_column = "I"

tests/QARegressionTests/test_Issues/test_CoreIssue1204.py

@@ -1,40 +1,40 @@
-import subprocess
-import pytest
-from conftest import get_python_executable
-
-
-@pytest.mark.regression
-def test_non_existing_dataset_shows_helpful_error():
-    """Test that the engine displays a helpful error message if dataset files are not found"""
-    command = [
-        get_python_executable(),
-        "-m",
-        "core",
-        "validate",
-        "-s",
-        "sdtmig",
-        "-v",
-        "3.4",
-        "-dp",
-        "ds.json",
-        "-dp",
-        "ds2.json",
-    ]
-
-    process = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-    stdout, stderr = process.communicate()
-
-    stderr_text = stderr.decode()
-    stdout_text = stdout.decode()
-
-    assert process.returncode == 2, "Expected non-zero exit code"
-    assert (
-        "FileNotFoundError" not in stderr_text
-    ), "Should not show FileNotFoundError crash"
-    assert (
-        "Failed to execute script" not in stderr_text
-    ), "Should not show script execution failure"
-    assert "Files ds.json, ds2.json are not found" in stderr_text, (
-        f"Expected helpful error message about non-existing dataset files. "
-        f"stderr: {stderr_text}, stdout: {stdout_text}"
-    )
+import subprocess
+import pytest
+from conftest import get_python_executable
+
+
+@pytest.mark.regression
+def test_non_existing_dataset_shows_helpful_error():
+    """Test that the engine displays a helpful error message if dataset files are not found"""
+    command = [
+        get_python_executable(),
+        "-m",
+        "core",
+        "validate",
+        "-s",
+        "sdtmig",
+        "-v",
+        "3.4",
+        "-dp",
+        "ds.json",
+        "-dp",
+        "ds2.json",
+    ]
+
+    process = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+    stdout, stderr = process.communicate()
+
+    stderr_text = stderr.decode()
+    stdout_text = stdout.decode()
+
+    assert process.returncode == 2, "Expected non-zero exit code"
+    assert (
+        "FileNotFoundError" not in stderr_text
+    ), "Should not show FileNotFoundError crash"
+    assert (
+        "Failed to execute script" not in stderr_text
+    ), "Should not show script execution failure"
+    assert "Files ds.json, ds2.json are not found" in stderr_text, (
+        f"Expected helpful error message about non-existing dataset files. "
+        f"stderr: {stderr_text}, stdout: {stdout_text}"
+    )