Conversation
bde61b5 to
ec5c7b5
Compare
Member
Author
|
no longer necessary, Go un-broke this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #3980 , when complete.
In a nutshell:
gohasn't liked.gensince some time in 2018, but 1.16 was just released and now it's enforced.Doing anything with 1.16 with modules enabled produces errors like:
So this commit:
github.com/uber/cadence/{.gen,gen}To be complete, we'll need to make a new release of go.uber.org/cadence with similar changes, and import it here.
Unfortunately that PR is a fair bit more complex, so I'll wait for that to be decided before continuing here: cadence-workflow/cadence-go-client/pull/1057