feat: add devenv.preFlight for pre-init env injection#2783
Open
ap-1 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few of devenv's own subsystems (cachix push auth, substituter netrc) read environment variables at process startup, before any module-declared
env.Xis exported into the resulting shell. Values fetched at module-evaluation time can't reach those subsystems.For organizations that store
CACHIX_AUTH_TOKENin a secret manager (Vault, OpenBao, 1Password, secretspec), this means there's no way to feed the token into devenv-core's cachix init without each developer runningcachix authtoken <token>manually first. The cachix daemon spawns with whatever env devenv was launched with, which doesn't include anything modules declare.This PR adds a new
devenv.preFlightoption (attrsOf submodule { command = str; }). Each command is run, in alphabetical key order, before subsystem initialization. Lines ofKEY=valuewritten to stdout are merged into devenv's process environment, so the subsequentenv::var()reads indevenv-core(cachix, etc.) see them.