Skip to content

fix(collator): fix validation for already skipped blocks#1112

Merged
Rexagon merged 1 commit into
masterfrom
fix/skip-cancelled-validation
Jul 1, 2026
Merged

fix(collator): fix validation for already skipped blocks#1112
Rexagon merged 1 commit into
masterfrom
fix/skip-cancelled-validation

Conversation

@Rexagon

@Rexagon Rexagon commented Jul 1, 2026

Copy link
Copy Markdown
Member

There was a possibility that an already skipped block could be later used to start a validation task. It causes some races in tests and might as well waste resources on lagging nodes.

@Rexagon Rexagon requested review from Mododo and SmaGMan July 1, 2026 14:44
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1112

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1112
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1112 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.89%. Comparing base (5e6b378) to head (d0c1901).

Files with missing lines Patch % Lines
collator/src/validator/impls/std_impl/session.rs 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   59.89%   59.89%   -0.01%     
==========================================
  Files         484      484              
  Lines       82715    82726      +11     
  Branches    82715    82726      +11     
==========================================
+ Hits        49541    49545       +4     
- Misses      30826    30832       +6     
- Partials     2348     2349       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rexagon Rexagon force-pushed the fix/skip-cancelled-validation branch from de96a53 to d0c1901 Compare July 1, 2026 15:35

@SmaGMan SmaGMan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rexagon Rexagon added this pull request to the merge queue Jul 1, 2026
Merged via the queue into master with commit 525bcc4 Jul 1, 2026
23 checks passed
@Rexagon Rexagon deleted the fix/skip-cancelled-validation branch July 1, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants