perf(core): speed-up raw import#1099
Draft
0xdeafbeef wants to merge 1 commit into
Draft
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=1099Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
+ Coverage 60.10% 60.14% +0.04%
==========================================
Files 473 474 +1
Lines 80197 80848 +651
Branches 80197 80848 +651
==========================================
+ Hits 48200 48625 +425
- Misses 29681 29878 +197
- Partials 2316 2345 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw Persistent State Import Benchmark
Benchmarked on downloaded testnet persistent state:
-1:8000000000000000:20768185:...41,701,7761,892,012,163bytes2,248,610,105Result
1002.125s236.687s4.23xfaster,-76.4%1020.91s239.18s4.27xfaster738.133s134.552s5.49xfaster,-81.8%589.186s0.208sworker-summed182.228s0s66.305s61.038s-7.9%417141910xfewerWhat changed
Instead of reading every temp cell back from RocksDB during finalization, the import path now builds an indexed byte store and applies cells directly from it.
Also we traverse the tree in parallel now.
The main wins are:
temp_cellsduring applytemp_cellsmaterialization writestodo: use rocksdb based on free ram. Now it uses 7gib for 41m cell state.