-
Notifications
You must be signed in to change notification settings - Fork 2
Add an inline search variant for the Combobox #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaieds
wants to merge
6
commits into
staging
Choose a base branch
from
select-component/inline-search
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4700dc5
Delete component-data.json
jaieds 534c9de
Add CLAUDE.md
jaieds b7ebf19
feat(select): add inlineSearch variant with shadcn-style UX
jaieds 92a322a
Add claude skills
jaieds c03b80a
Add a few more test cases to the select component
jaieds 2098698
Update changelog.txt
jaieds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "attribution": { | ||
| "commit": "", | ||
| "pr": "" | ||
| }, | ||
| "permissions": { | ||
|
jaieds marked this conversation as resolved.
Outdated
|
||
| "allow": [ | ||
| "Bash(npm run *)", | ||
| "Bash(npm install *)", | ||
| "Bash(npm view *)", | ||
| "Bash(npx tsc *)", | ||
| "Bash(npx eslint *)", | ||
| "Bash(npx stylelint *)", | ||
| "Bash(npx prettier *)", | ||
| "Bash(git status)", | ||
| "Bash(grep *)", | ||
| "Bash(find * -name *)", | ||
|
jaieds marked this conversation as resolved.
Outdated
|
||
| "Bash(ls *)" | ||
| ] | ||
| }, | ||
| "statusLine": { | ||
| "type": "command", | ||
| "command": "bash \"/Users/jaieds/.claude/plugins/cache/caveman/caveman/63e797cd753b/hooks/caveman-statusline.sh\"" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/accessibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/frontend-design |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/playwright-best-practices |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/seo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/tailwind-css-patterns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/typescript-advanced-types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/vite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/vitest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| # force-ui | ||
|
|
||
| React component library for BSF projects. Publishes to GitHub Package Registry as `@bsf/force-ui`. | ||
|
|
||
| ## Stack | ||
|
|
||
| - **React 18** + **TypeScript** — component authoring | ||
| - **Vite** — build (CJS + ESM outputs) | ||
| - **Tailwind CSS 3** — styling via `cn()` utility | ||
| - **Storybook 10** — component dev + visual regression (Chromatic) | ||
| - **Vitest** — unit/interaction tests (Storybook play functions) | ||
| - **ESLint + Prettier + Stylelint** — linting | ||
|
|
||
| ## Commands | ||
|
|
||
| ```bash | ||
| npm run build # production build | ||
| npm run start # build in watch mode | ||
| npm run storybook # dev server at :6006 | ||
| npm run test # vitest (storybook project) | ||
| npm run test:watch # vitest in watch mode | ||
| npm run lint:js-fix # eslint + prettier fix | ||
| npm run lint:css-fix # stylelint fix | ||
| npx tsc --noEmit # type-check only | ||
| ``` | ||
|
|
||
| ## Component Conventions | ||
|
|
||
| Each component lives at `src/components/{name}/`: | ||
| ``` | ||
| {name}.tsx # component implementation | ||
| {name}.stories.tsx # Storybook stories | ||
| index.ts # named exports | ||
| readme.md # usage docs | ||
| ``` | ||
|
|
||
| ### Authoring pattern | ||
|
|
||
| ```tsx | ||
| import { forwardRef } from 'react'; | ||
| import { cn } from '@/utilities/functions'; | ||
|
|
||
| export interface FooProps { | ||
| /** JSDoc for every prop — Storybook renders these as docs */ | ||
| variant?: 'primary' | 'secondary'; | ||
| className?: string; | ||
| } | ||
|
|
||
| const Foo = forwardRef<HTMLDivElement, FooProps>( | ||
| ({ variant = 'primary', className, ...props }, ref) => { | ||
| return ( | ||
| <div ref={ref} className={cn('base-classes', className)} {...props} /> | ||
| ); | ||
| } | ||
| ); | ||
| Foo.displayName = 'Foo'; | ||
| export default Foo; | ||
| ``` | ||
|
|
||
| - Always `forwardRef` + `displayName` | ||
| - Export props interface with component | ||
| - `cn()` from `@/utilities/functions` for class merging | ||
| - Path alias `@/` → `src/` | ||
| - Props interface JSDoc required — Storybook autodocs reads them | ||
|
|
||
| ## Exports | ||
|
|
||
| New components go in `src/components/index.ts` and `src/index.ts`. | ||
|
|
||
| ## Testing | ||
|
|
||
| Tests via Storybook `play` functions using `@storybook/test`. Run: `npm run test`. Add `play` to stories for interaction coverage. | ||
|
|
||
| ## Current Focus | ||
|
|
||
| _Update this section with current sprint/task context._ | ||
|
|
||
| ## Gotchas | ||
|
|
||
| - `peerDependencies` for `react`/`react-dom` — consumers supply; don't bundle | ||
| - Storybook on `:6006`; `test-storybook` needs Storybook running first | ||
| - Chromatic upload needs `CHROMATIC_PROJECT_TOKEN` env var | ||
| - GitHub Package Registry — `npm publish` needs `NPM_TOKEN` with `write:packages` scope | ||
| - Add `.claude/settings.local.json` to local `.gitignore` for personal settings |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.