Skip to content

Allow generics for derived signal #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oliwenmandiamond wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow generics for derived signal #1276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
941c6a0
Allow generics for derived signal
oliwenmandiamond May 22, 2026
a9488d8
Impove and simplify the check
oliwenmandiamond May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/ophyd_async/core/_derived_signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,22 @@ def __init__(
raise TypeError(msg)

for k in set(expected.keys()):
if isinstance(expected[k], type):
if not issubclass(received[k], expected[k]):
raise TypeError(msg)
elif isinstance(expected[k], TypeVar):
if isinstance(expected[k], TypeVar):
bound = expected[k].__bound__
if isinstance(bound, type) and not issubclass(
received[k], bound
):
raise TypeError(msg)
if isinstance(received[k], TypeVar):
bound = received[k].__bound__
if isinstance(bound, type) and not issubclass(
expected[k], bound
):
raise TypeError(msg)
if isinstance(received[k], type) and isinstance(expected[k], type):
if not issubclass(received[k], expected[k]):
raise TypeError(msg)

self._set_derived_takes_dict = (
is_typeddict(_get_first_arg_datatype(set_derived)) if set_derived else False
)
Expand Down
Loading