Skip to content

fix: correctly check pmac execution status and messages - #1235

Merged
shihab-dls merged 8 commits into
mainfrom
1107_check_status
Jul 13, 2026
Merged

fix: correctly check pmac execution status and messages#1235
shihab-dls merged 8 commits into
mainfrom
1107_check_status

Conversation

@shihab-dls

Copy link
Copy Markdown
Contributor

Closes #1107

Checks PMAC execute_status and execute_message after execute_profile returns, and raises appropriate error messages if not successful.

@shihab-dls

shihab-dls commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Should: add tests to cover failed execution cases to fix codecov.

Comment thread src/ophyd_async/epics/pmac/_pmac_trajectory.py Outdated
Comment thread src/ophyd_async/epics/pmac/_pmac_io.py
@shihab-dls
shihab-dls requested a review from coretl July 10, 2026 16:56
@shihab-dls
shihab-dls merged commit 9e30beb into main Jul 13, 2026
24 checks passed
@shihab-dls
shihab-dls deleted the 1107_check_status branch July 13, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check build, execute and append status before running a scan.

2 participants