fix: correctly check pmac execution status and messages#1235
Open
shihab-dls wants to merge 4 commits into
Open
fix: correctly check pmac execution status and messages#1235shihab-dls wants to merge 4 commits into
shihab-dls wants to merge 4 commits into
Conversation
Contributor
Author
|
Should: add tests to cover failed execution cases to fix codecov. |
shihab-dls
force-pushed
the
1107_check_status
branch
from
3e1eba4 to
20ecc56
Compare
coretl
reviewed
Apr 8, 2026
Comment on lines
+175
to
+179
| async for pmac_status in observe_value( | ||
| self.pmac_ref().trajectory.execute_profile, done_timeout=DEFAULT_TIMEOUT | ||
| ): | ||
| if pmac_status is False: | ||
| break |
Collaborator
There was a problem hiding this comment.
This was meant to observe_value on execute_status and raise with the value of execute_message if it fails. A similar check is needed where we do build_profile and append_profile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1107
Checks PMAC
execute_statusandexecute_messageafterexecute_profilereturns, and raises appropriate error messages if not successful.