-
Notifications
You must be signed in to change notification settings - Fork 11
Dynamic host #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imadjamil
wants to merge
11
commits into
bluenote10:master
Choose a base branch
from
imadjamil:dev/dynamic_host
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dynamic host #19
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
21d5424
Update server.py
imadjamil 0838649
Update server.py
imadjamil 1ad37ad
Redirecting to the server host address instead of localhost
imadjamil 807759e
Merge branch 'master' of https://github.com/bluenote10/tabloo into bl…
imadjamil 481f84f
Merging 2021 upstream updates
imadjamil 182af76
Merge branch 'bluenote10-master'
imadjamil 8ce5da6
adding server_host as a parameter
imadjamil ffbb465
add todo comment
imadjamil 3fa9ac5
add dynamic host todo comment
imadjamil 4e48eaf
remove perso file
imadjamil f096e2b
fmt fix
imadjamil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be dynamic in some way. Could we guess the address of the local device on startup? or we're obliged to get it from some sort of config?