Skip to content

Fix for broken signup page for the newsletter #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enyanil merged 2 commits into from
Sep 7, 2026
Merged

Fix for broken signup page for the newsletter #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06766b2
Updated links and removed old no longer working page
enyanil Sep 2, 2026
b13cd8f
Fixing tests for coming soon button
enyanil Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/_includes/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ <h5 class="footer-col-heading">Trust &amp; Legal</h5>
<div class="col-6 col-md-3 footer-col">
<h5 class="footer-col-heading">Cooperation</h5>
<ul class="footer-col-links">
<li><a href="/signup/">Sign up for newsletter</a></li>
<li><a href="https://eepurl.com/hiqdJ9">Sign up for newsletter</a></li>
<li><a href="/about/distributors/">Distributors</a></li>
<li><a href="/about/partners/">Partners</a></li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion src/_plugins/coming_soon.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def render(context)
<div class="col-md-12">
<button type="button" class="buy-button" disabled><i class="fa-solid fa-cart-shopping fa-fw"></i>Coming soon</button>
<h4>Soon available in stores,
<a title="Signup for newsletter" href="/signup/">sign up for our newsletter.</a>
<a title="Signup for newsletter" href="https://eepurl.com/hiqdJ9">sign up for our newsletter.</a>
</h4>
</div>
</div>'
Expand Down
45 changes: 0 additions & 45 deletions src/_scss/_mailsignup.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/css/kraken.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
@import "buttons-kraken";
@import "screenreader";
@import "left-menu";
@import "mailsignup";
@import "sidebar";
@import "pastie";
@import "frontpage";
Expand Down
51 changes: 0 additions & 51 deletions src/signup.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/_plugins/coming_soon_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def test_that_tag_is_rendered
expected = '<div class="row">
<div class="col-md-12">
<button type="button" class="buy-button" disabled><i class="fa-solid fa-cart-shopping fa-fw"></i>Coming soon</button>
<h4>Soon available in stores, <a title="Signup for newsletter" href="/signup/">sign up for our newsletter.</a></h4>
<h4>Soon available in stores, <a title="Signup for newsletter" href="https://eepurl.com/hiqdJ9">sign up for our newsletter.</a></h4>
</div>
</div>'

Expand Down