feat: support structured logging in Promtail#307
Merged
Conversation
davidlougheed
changed the title
v-rocheleau
reviewed
Mar 3, 2025
v-rocheleau
left a comment
v-rocheleau
left a comment
Contributor
There was a problem hiding this comment.
Tested with reference service in structlog mode, works well!
Was able to parse logs from reference, and filter for access logs where http status >= 400 for instance. Will be useful for dashboard creation.
v-rocheleau
reviewed
Mar 4, 2025
Contributor
There was a problem hiding this comment.
We need to replace Promtail with Alloy, just made a PR for it.
I can use the updated Promtail config to re-generate the Alloy config with these changes.
Maybe merge this in refact/alloy-migrate instead?
davidlougheed
force-pushed
the
feat/structured-logging
branch
from
a50030d to
41f2e88
Compare
davidlougheed
force-pushed
the
refact/alloy-migrate
branch
from
64e75e5 to
1afb4aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for v19