Add mocha tests for web/common-function.js unpacker_filter and helpers - #2509
Merged
bitwiseman merged 1 commit intoJul 11, 2026
Merged
Conversation
Covers any(), mergeObjects(), and unpacker_filter() with a regression case for beautifier#1546 (multiple leading comments losing formatting).
Contributor
Author
|
Thank you
…On Sun, 12 Jul 2026 at 00:17, Liam Newman ***@***.***> wrote:
Merged #2509 <#2509> into
main.
—
Reply to this email directly, view it on GitHub
<#2509?email_source=notifications&email_token=BE3TNQAFBB6UA6ZFLWGNYH35ELDHHA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZYGYZDQOJWGY2DHJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-27862896643>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE3TNQCOV3DN24M47VRGZW35ELDHHAVCNFSNUABBKJSXA33TNF2G64TZHM4DIOBSGI5US43TOVSTWNBYGM2TSMZXGAZDNILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BE3TNQBE6YRU65NL3I2JI535ELDHHA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZYGYZDQOJWGY2DHJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BE3TNQANUIQRCATEZ2EPJPT5ELDHHA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZYGYZDQOJWGY2DHJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers any(), mergeObjects(), and unpacker_filter() with a regression case for #1546 (multiple leading comments losing formatting).
Description
Adds mocha tests for
web/common-function.js, coveringany(),mergeObjects(), andunpacker_filter(). Includes a regression test for the multiple-leading-comments bug fixed in #1546, so this class of bug can't silently reappear.Fixes Issue: #1547
Test plan
./node_modules/.bin/mocha js/test/web/test_common-function.jspasses (10/10)Before Merge Checklist
main)